Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename internal package #11

Merged
merged 8 commits into from
Jun 15, 2022
Merged

rename internal package #11

merged 8 commits into from
Jun 15, 2022

Conversation

adriangb
Copy link
Owner

No description provided.

@adriangb
Copy link
Owner Author

Hi @messense , sorry to bother you, do you see any obvious reason why this would be failing in CI? It runs for me locally even after a git clean -fdx.

@messense
Copy link
Contributor

I think it's because Python try to import the local one first, see PyO3/maturin#490.

I'd keep the python/ folder to avoid such problem, the internal module rename should be fine.

@messense
Copy link
Contributor

It's the exact reason we changed the default template to include a python folder in PyO3/maturin#855

@messense
Copy link
Contributor

😅 There was a bug when package.metadata.maturin.name and python-source are both set and name contains dot, I think I've fixed it in https://github.com/PyO3/maturin/pull/969/files#diff-87a24e61912b4f23e30d6031f5adc136adfa6008772880ae53a355cedfaee466R104

You can try 0.13.0-beta.6 when it's out.

@adriangb
Copy link
Owner Author

Thanks yeah that's why I originally switched the layout

@messense
Copy link
Contributor

messense commented Jun 15, 2022

We haven't implement reading maturin version from pyproject.toml in maturin-action yet, so you need to specify it manually:

- uses: messense/maturin-action@v1
  with:
    maturin-version: v0.13.0-beta.6

@messense
Copy link
Contributor

messense commented Jun 15, 2022

There were some breaking changes in v0.13, --no-sdist is replaced by --sdist, see PyO3/maturin#955

@adriangb adriangb merged commit 048d9ea into main Jun 15, 2022
@adriangb adriangb deleted the rename-internal-package branch June 15, 2022 15:23
@adriangb
Copy link
Owner Author

Thank you @messense !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants